Despaghettify jam code #31

Merged

outfrost merged 19 commits from cleanup into main

2020-10-15 19:25:28 +00:00

outfrost commented

2020-08-12 00:54:34 +00:00

(Migrated from github.com)

Parameterise initial freeze time per level
Make camera setup per-level, factor out camera control
Factor out separate functionality modules
Replace preloads with class names
Implement GroupMessenger for game state changes
A bunch of other refactors to make the code easier to work with
Remove trailing whitespace

Breaks lifting items with the robot's arm (see #3).

Closes #26

Aside: The diff here is quite lengthy. A more convenient way to see what I changed might be to directly look at the code on main and cleanup, as a 'before' and 'after'.

* Parameterise initial freeze time per level * Make camera setup per-level, factor out camera control * Factor out separate functionality modules * Replace preloads with class names * Implement `GroupMessenger` for game state changes * A bunch of other refactors to make the code easier to work with * Remove trailing whitespace Breaks lifting items with the robot's arm (see #3). Closes #26 > Aside: The diff here is quite lengthy. A more convenient way to see what I changed might be to directly look at the code on `main` and `cleanup`, as a 'before' and 'after'.

L1Q (Migrated from github.com) reviewed 2020-08-12 00:54:34 +00:00

outfrost commented

2020-08-26 02:00:12 +00:00

(Migrated from github.com)

I've cleaned up most of our code, but I haven't looked deep inside Robot.gd yet. I feel like it might give me a headscratch. @L1Q would you be able to add a few comments here and there on the cleanup branch so I have a rough idea what happens where? Then I could finish this initial refactor quite quickly. To be clear I'm not asking you to fix/improve/refactor the implementation itself, that's a separate task for a separate PR.

Aside: The diff here is quite lengthy. A more convenient way to see what I changed might be to directly look at the code on main and cleanup, as a 'before' and 'after'.

I've cleaned up most of our code, but I haven't looked deep inside Robot.gd yet. I feel like it might give me a headscratch. @L1Q would you be able to add a few comments here and there on the `cleanup` branch so I have a rough idea what happens where? Then I could finish this initial refactor quite quickly. To be clear I'm not asking you to fix/improve/refactor the implementation itself, that's a separate task for a separate PR. Aside: The diff here is quite lengthy. A more convenient way to see what I changed might be to directly look at the code on `main` and `cleanup`, as a 'before' and 'after'.

outfrost commented

2020-09-24 01:40:22 +00:00

(Migrated from github.com)

I'm in the process of finishing the cleanup of Robot.gd as well myself now. Indeed scratching my head over why some things were necessary, but making progress.

outfrost commented

2020-09-28 00:34:16 +00:00

(Migrated from github.com)

Alright, I had a plow through Robot.gd, seems more organised now. Please review.

666Savior (Migrated from github.com) approved these changes 2020-10-15 08:07:44 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

L1Q

666Savior